Skip to contentSkip to conversation

libtool: fix resolve of lt_sysroot

PATCH Superseded Hans Beckérus 2 participants 7 messages Sep 10, 2013

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 libtool: fix resolve of lt_sysroot

This patch updates libtool.m4 (and its output) to resolve a problem with variable 'lt_sysroot' not being properly updated if the option '--with[-libtool]-sysroot' is not provided when running the 'configure' script for a package.

According to the help text ouput from 'configure':
--with-libtool-sysroot=DIR Search for dependent libraries within DIR
(or the compiler's sysrooot if not specified).

Due to swapped cases in a switch statement, when checking if the option was specified or not, wrong actions were taken resulting in an incorrect sysroot and failures to properly locate e.g. .la files.

For current upstream status see:
http://lists.gnu.org/archive/html/bug-libtool/2013-09/msg00005.html

Signed-off-by Hans Beckerus <hans.beckerus at gmail.com>

---
meta/recipes-devtools/libtool/libtool-2.4.2.inc | 1 +
.../libtool/libtool/fix-resolve-lt-sysroot.patch | 35 ++++++++++++++++++++++

2 files changed, 36 insertions(+)

create mode 100644 meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch

meta/recipes-devtools/libtool/libtool-2.4.2.inc +1 -0
index bb4ddf0..92e4949 100644
@@ -20,6 +20,7 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
                  file://respect-fstack-protector.patch \
            file://norm-rpath.patch \
            file://dont-depend-on-help2man.patch \
+           file://fix-resolve-lt-sysroot.patch \
           "
 SRC_URI[md5sum] = "d2f3b7d4627e69e13514a40e72a24d50"
meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch new file +35 -0
new file mode 100644
index 0000000..5a6335b
@@ -0,0 +1,35 @@
+
+Upstream-Status: Pending
+
+This patch updates libtool.m4 (and its output) to resolve a problem
+with variable 'lt_sysroot' not being properly updated if the option
+'--with[-libtool]-sysroot' is not provided when running the 'configure'
+script for a package.
+
+I have also reported the problem to libtool here
+
+http://lists.gnu.org/archive/html/bug-libtool/2013-09/msg00005.html
+
+Signed-off-by: Hans Beckerus <hans.beckerus at gmail.com>
+---
+diff -ur libtool-2.4.2.orig/libltdl/m4/libtool.m4 libtool-2.4.2/libltdl/m4/libtool.m4
+--- libtool-2.4.2.orig/libltdl/m4/libtool.m4           2013-09-05 10:37:24.690013000 +0200
++++ libtool-2.4.2/libltdl/m4/libtool.m4 2013-09-05 12:05:51.560281000 +0200
+@@ -1234,7 +1234,7 @@
+ dnl in case the user passed a directory name.
+ lt_sysroot=
+ case ${with_libtool_sysroot} in #(
+- yes)
++ no)
+    if test "$GCC" = yes; then
+      lt_sysroot=`$CC --print-sysroot 2>/dev/null`
+    fi
+@@ -1242,7 +1242,7 @@
+  /*)
+    lt_sysroot=`echo "$with_libtool_sysroot" | sed -e "$sed_quote_subst"`
+    ;; #(
+- no|'')
++ yes|'')
+    ;; #(
+  *)
+    AC_MSG_RESULT([${with_libtool_sysroot}])

--
1.8.3.3

#1 lore raw

Could someone please verify if this patch (original v3 post) can be saved without line-feed corruption? It seems very client dependent how a message is saved, irrespective of source format. Some client seems to cut lines like crazy, others does not.

Thanks.
Hans

Quoted 161 lines · Hans Beckérus

This patch updates libtool.m4 (and its output) to resolve a problem

with variable 'lt_sysroot' not being properly updated if the option

'--with[-libtool]-sysroot' is not provided when running the 'configure'

script for a package.

According to the help text ouput from 'configure':

--with-libtool-sysroot=DIR Search for dependent libraries within DIR

(or the compiler's sysrooot if not specified).

Due to swapped cases in a switch statement, when checking if the option

was specified or not, wrong actions were taken resulting in an

incorrect sysroot and failures to properly locate e.g. .la files.

For current upstream status see:

http://lists.gnu.org/archive/html/bug-libtool/2013-09/msg00005.html

Signed-off-by Hans Beckerus <hans.beckerus at gmail.com>

---

meta/recipes-devtools/libtool/libtool-2.4.2.inc | 1 +

.../libtool/libtool/fix-resolve-lt-sysroot.patch | 35
++++++++++++++++++++++

2 files changed, 36 insertions(+)

create mode 100644 meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch

meta/recipes-devtools/libtool/libtool-2.4.2.inc +0 -0

index bb4ddf0..92e4949 100644

--- a/meta/recipes-devtools/libtool/libtool-2.4.2.inc

+++ b/meta/recipes-devtools/libtool/libtool-2.4.2.inc

meta/recipes-devtools/libtool/libtool-2.4.2.inc +1 -0
@@ -20,6 +20,7 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
 
                  file://respect-fstack-protector.patch \
 
            file://norm-rpath.patch \
 
            file://dont-depend-on-help2man.patch \
 
+           file://fix-resolve-lt-sysroot.patch \
 
           "
 
 SRC_URI[md5sum] = "d2f3b7d4627e69e13514a40e72a24d50"

diff --git a/meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch b/meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch

new file mode 100644

index 0000000..5a6335b

--- /dev/null

+++ b/meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch

meta/recipes-devtools/libtool/libtool-2.4.2.inc +15 -0
@@ -0,0 +1,35 @@
 
+
 
+Upstream-Status: Pending
 
+
 
+This patch updates libtool.m4 (and its output) to resolve a problem
 
+with variable 'lt_sysroot' not being properly updated if the option
 
+'--with[-libtool]-sysroot' is not provided when running the 'configure'
 
+script for a package.
 
+
 
+I have also reported the problem to libtool here
 
+
 
+http://lists.gnu.org/archive/html/bug-libtool/2013-09/msg00005.html
 
+
 
+Signed-off-by: Hans Beckerus <hans.beckerus at gmail.com>
 
+---
 
+diff -ur libtool-2.4.2.orig/libltdl/m4/libtool.m4

libtool-2.4.2/libltdl/m4/libtool.m4

+--- libtool-2.4.2.orig/libltdl/m4/libtool.m4 2013-09-05
10:37:24.690013000 +0200

++++ libtool-2.4.2/libltdl/m4/libtool.m4 2013-09-05 12:05:51.560281000 +0200

+@@ -1234,7 +1234,7 @@

+ dnl in case the user passed a directory name.

+ lt_sysroot=

+ case ${with_libtool_sysroot} in #(

+- yes)

++ no)

meta/recipes-devtools/libtool/libtool-2.4.2.inc +12 -1
+    if test "$GCC" = yes; then
 
+      lt_sysroot=`$CC --print-sysroot 2>/dev/null`
 
+    fi
 
+@@ -1242,7 +1242,7 @@
 
+  /*)
 
+    lt_sysroot=`echo "$with_libtool_sysroot" | sed -e "$sed_quote_subst"`
 
+    ;; #(
 
+- no|'')
 
++ yes|'')
 
+    ;; #(
 
+  *)
 
+    AC_MSG_RESULT([${with_libtool_sysroot}])
 
--

1.8.3.3

#2 lore raw
Quoted 8 lines · Hans Beckérus

Could someone please verify if this patch (original v3 post) can be saved without line-feed corruption? It seems very client dependent how a message is saved, irrespective of source format. Some client seems to cut lines like crazy, others does not.

Thanks.
Hans

Looking at "Show Original" in gmail still shows this to be garbled. Perhaps save it as a .patch file and attach that to an email? That should prevent any mail client from touching it.

Signature · 4 lines
Paul Barker

Email: [email protected]
http://www.paulbarker.me.uk
#3 lore raw
Quoted 6 lines · Paul Barker
Quoted 5 lines · Hans Beckérus

Could someone please verify if this patch (original v3 post) can be saved without line-feed corruption? It seems very client dependent how a message is saved, irrespective of source format. Some client seems to cut lines like crazy, others does not.

Quoted 8 lines
Quoted 3 lines

Thanks.
Hans

Looking at "Show Original" in gmail still shows this to be garbled. Perhaps save it as a .patch file and attach that to an email? That should prevent any mail client from touching it.

Oh. But hang on here. Is it allowed to commit patches in the form of an attachment?
Then why are we at all messing with the formatting and using git send-email to avoid white-spaces etc?
If attachments are allowed then that will definitely save me some work ;)

Thanks.
Hans

Quoted 5 lines

--
Paul Barker

Email: [email protected]
http://www.paulbarker.me.uk

#4 lore raw
Quoted 15 lines · Hans Beckérus
Quoted 6 lines · Paul Barker
Quoted 5 lines · Hans Beckérus

Could someone please verify if this patch (original v3 post) can be saved without line-feed corruption? It seems very client dependent how a message is saved, irrespective of source format. Some client seems to cut lines like crazy, others does not.

Quoted 8 lines
Quoted 3 lines

Thanks.
Hans

Looking at "Show Original" in gmail still shows this to be garbled. Perhaps save it as a .patch file and attach that to an email? That should prevent any mail client from touching it.

Quoted 6 lines

Oh. But hang on here. Is it allowed to commit patches in the form of an attachment?
Then why are we at all messing with the formatting and using git send-email to avoid white-spaces etc?
If attachments are allowed then that will definitely save me some work ;)

Ok, I've looked again and
http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
doesn't mention attached patches as allowed. This is what the -contrib repos were created for, perhaps you could request access to
http://git.openembedded.org/openembedded-core-contrib/ and push a branch there, then send a pull request.

Signature · 4 lines
Paul Barker

Email: [email protected]
http://www.paulbarker.me.uk
#5 lore raw
Quoted 23 lines · Paul Barker
Quoted 15 lines · Hans Beckérus
Quoted 6 lines · Paul Barker
Quoted 5 lines · Hans Beckérus

Could someone please verify if this patch (original v3 post) can be saved without line-feed corruption? It seems very client dependent how a message is saved, irrespective of source format. Some client seems to cut lines like crazy, others does not.

Quoted 8 lines
Quoted 3 lines

Thanks.
Hans

Looking at "Show Original" in gmail still shows this to be garbled. Perhaps save it as a .patch file and attach that to an email? That should prevent any mail client from touching it.

Quoted 6 lines

Oh. But hang on here. Is it allowed to commit patches in the form of an attachment?
Then why are we at all messing with the formatting and using git send-email to avoid white-spaces etc?
If attachments are allowed then that will definitely save me some work ;)

Quoted 7 lines

Ok, I've looked again and
http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
doesn't mention attached patches as allowed. This is what the -contrib repos were created for, perhaps you could request access to
http://git.openembedded.org/openembedded-core-contrib/ and push a branch there, then send a pull request.

Yes, or I will just try to find a simple stupid mail client that does not mess up the formatting.
I will try later today from a different client. That will be the last attempt. I am making a complete fool out of myself already ;)

Thanks.
Hans

Quoted 5 lines

--
Paul Barker

Email: [email protected]
http://www.paulbarker.me.uk

#6 lore raw
Quoted 5 lines · Hans Beckérus

Yes, or I will just try to find a simple stupid mail client that does not mess up the formatting.
I will try later today from a different client. That will be the last attempt. I am making a complete fool out of myself already ;)

You should have seen the first patches I posted! Don't worry about looking like a fool, we were all new to this at some point.

Signature · 4 lines
Paul Barker

Email: [email protected]
http://www.paulbarker.me.uk